Add support for arm64 image #81
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds multi-architecture Docker image support, enabling the cloudstack-kubernetes-provider to run on both AMD64 and ARM64 platforms. The changes implement cross-platform building using Docker Buildx and update the CI/CD pipeline to build and push multi-arch images.
Key changes include:
- Modified Dockerfile to support cross-compilation with platform-specific build arguments
- Updated GitHub Actions workflow to use Docker Buildx for multi-platform builds
- Added registry-based layer caching to optimize build times
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Dockerfile | Added build platform arguments and configured cross-compilation for Go builds targeting both amd64 and arm64 architectures |
| .github/workflows/build-docker-image.yml | Replaced simple docker build/push commands with Docker Buildx setup and multi-platform build-push action, including registry cache optimization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vishesh92
force-pushed
the
add-arm64-image
branch
from
48999fc to
26ac0f2
Compare
vishesh92
force-pushed
the
add-arm64-image
branch
from
26ac0f2 to
268a6ee
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pearl1594
left a comment
Pearl1594
left a comment
There was a problem hiding this comment.
code lgtm. Just a few questions to understand a few changes.
3 participants
Fixes #80